Skip to content

Fix show#35

Merged
luciemac merged 2 commits into
Kitware:masterfrom
Jo-Byr:fix-show
Jan 19, 2026
Merged

Fix show#35
luciemac merged 2 commits into
Kitware:masterfrom
Jo-Byr:fix-show

Conversation

@Jo-Byr

@Jo-Byr Jo-Byr commented Jan 16, 2026

Copy link
Copy Markdown
Contributor

Fix show condition in vue3

Add example for show condition

Fix show condition not working in vue3
@Jo-Byr Jo-Byr requested review from jourdain and luciemac January 16, 2026 10:25

@jourdain jourdain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jourdain

jourdain commented Jan 16, 2026

Copy link
Copy Markdown
Collaborator

But you have a formatting issue... And your commit messages are not coherent with version bump.

Adding the example should not trigger a new release as the bundled library is not changing... (use docs(example): ...)

@jourdain

Copy link
Copy Markdown
Collaborator

@luciemac feel free to merge once you are done reviewing.

@luciemac luciemac merged commit f31cdf7 into Kitware:master Jan 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants